lkml.org 
[lkml]   [2019]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] EDAC: remove set but not used variable 'ecc_loc'
From
Date


On 2019/12/14 7:11, Luck, Tony wrote:
> On Fri, Dec 13, 2019 at 08:10:36PM +0800, yu kuai wrote:
>> @@ -499,7 +498,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan,
>> pci_read_config_dword(pdev, I5100_REDMEMA, &dw2);
>> syndrome = dw2;
>> pci_read_config_dword(pdev, I5100_REDMEMB, &dw2);
>> - ecc_loc = i5100_redmemb_ecc_locator(dw2);
>> }
>>
>> if (i5100_validlog_recmemvalid(dw)) {
>
> This deletes the only call to i5100_redmemb_ecc_locator(). Should
> we delete the definition of the function too?
Thank you for your response!
Yes, I think we can do that.

Thanks
Yu Kuai
>
> Is it worth making cosmetic cleanups to a driver for 12 year old h/w?
>
> -Tony
>
> .
>

\
 
 \ /
  Last update: 2019-12-16 02:12    [W:0.035 / U:1.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site