lkml.org 
[lkml]   [2019]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] openat2: switch to __attribute__((packed)) for open_how
Date
* Aleksa Sarai:

> diff --git a/tools/testing/selftests/openat2/helpers.h b/tools/testing/selftests/openat2/helpers.h
> index 43ca5ceab6e3..eb1535c8fa2e 100644
> --- a/tools/testing/selftests/openat2/helpers.h
> +++ b/tools/testing/selftests/openat2/helpers.h
> @@ -32,17 +32,16 @@
> * O_TMPFILE} are set.
> *
> * @flags: O_* flags.
> - * @mode: O_CREAT/O_TMPFILE file mode.
> * @resolve: RESOLVE_* flags.
> + * @mode: O_CREAT/O_TMPFILE file mode.
> */
> struct open_how {
> - __aligned_u64 flags;
> + __u64 flags;
> + __u64 resolve;
> __u16 mode;
> - __u16 __padding[3]; /* must be zeroed */
> - __aligned_u64 resolve;
> -};
> +} __attribute__((packed));
>
> -#define OPEN_HOW_SIZE_VER0 24 /* sizeof first published struct */
> +#define OPEN_HOW_SIZE_VER0 18 /* sizeof first published struct */
> #define OPEN_HOW_SIZE_LATEST OPEN_HOW_SIZE_VER0

A userspace ABI that depends on GCC extensions probably isn't a good
idea. Even with GCC, it will not work well with some future
extensions because it pretty much rules out having arrays or other
members that are access through pointers. Current GCC does not carry
over the packed-ness of the struct to addresses of its members.

\
 
 \ /
  Last update: 2019-12-15 20:50    [W:0.046 / U:1.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site