lkml.org 
[lkml]   [2019]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] btf: Some structs are doubled because of struct ring_buffer
On Fri, Dec 13, 2019 at 02:05:31PM -0500, Steven Rostedt wrote:

SNIP

> struct trace_array *tr = filp->private_data;
> - struct ring_buffer *buffer = tr->trace_buffer.buffer;
> + struct trace_buffer *buffer = tr->trace_buffer.buffer;
> unsigned long val;
> int ret;
>
> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> index 63bf60f79398..308fcd673102 100644
> --- a/kernel/trace/trace.h
> +++ b/kernel/trace/trace.h
> @@ -178,7 +178,7 @@ struct trace_option_dentry;
>
> struct trace_buffer {
> struct trace_array *tr;
> - struct ring_buffer *buffer;
> + struct trace_buffer *buffer;

perf change is fine, but 'trace_buffer' won't work because
we already have 'struct trace_buffer' defined in here

maybe we could change this name to trace_buffer_array?

thanks,
jirka

\
 
 \ /
  Last update: 2019-12-14 12:35    [W:0.051 / U:41.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site