lkml.org 
[lkml]   [2019]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] dt-bindings: display: panel: Add binding document for Xinpeng XPP055C272
Hi Heiko.


On Mon, Dec 09, 2019 at 03:42:07PM +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The XPP055C272 is a 5.5" 720x1280 DSI display.
Can we get the size info included in the title in the binding?
Then all relavant info is in the binding, and no git digging is needed.

>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> ---
> .../display/panel/xinpeng,xpp055c272.yaml | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> new file mode 100644
> index 000000000000..4515d44d189b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/sony,acx424akp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Xinpeng XPP055C272 720x1280 DSI panel
> +
> +maintainers:
> + - Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: xinpeng,xpp055c272
> + reg: true
> + backlight: true
> + port: true
> + reset-gpios: true
> + iovcc-supply:
> + description: regulator that supplies the iovcc voltage
> + vci-supply:
> + description: regulator that supplies the vci voltage
> +
> +required:
> + - compatible
> + - reg
One would assume the display also required power to operate.

> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + dsi@ff450000 {
> + panel@0 {
> + compatible = "xinpeng,xpp055c272";
> + reg = <0>;
> + backlight = <&backlight>;
> + iovcc-supply = <&vcc_1v8>;
> + vci-supply = <&vcc3v3_lcd>;
> + };
> + };
> +
> +...

With the few things mentioned above fixed:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

\
 
 \ /
  Last update: 2019-12-14 08:55    [W:0.054 / U:5.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site