lkml.org 
[lkml]   [2019]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] powerpc/devicetrees: Change 'gpios' to 'cs-gpios' on fsl,spi nodes
From
Date


Le 13/12/2019 à 22:34, Rob Herring a écrit :
> On Thu, Nov 28, 2019 at 12:16:35PM +0000, Christophe Leroy wrote:
>> Since commit 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO
>> descriptors"), the prefered way to define chipselect GPIOs is using
>> 'cs-gpios' property instead of the legacy 'gpios' property.
>
> This will break using a new dtb on a kernel without the above commit. Or
> with any OS that never made the change.

Why would anybody use a new dtb on an old kernel ? I have not tagged
this change for stable, it will only apply to DTBs in new kernels, won't
it ?

That's not the first time DTS have to change for new kernels. For
instance, some time ago I had to replace all 'gpios' property by a set
of 'rdy-gpio', 'nce-gpio', 'ale-gpio' and 'cle-gpio' properties to
continue using 'gpio-control-nand' driver.

>
> I'm fine with the doc change, but you should keep 'gpios' as deprecated.

Ok

Christophe

\
 
 \ /
  Last update: 2019-12-14 08:30    [W:0.048 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site