Messages in this thread Patch in this message |  | | From | Simon Geis <> | Subject | [PATCH v3 06/10] PCMCIA/i82092: move assignment out of if condition | Date | Fri, 13 Dec 2019 14:53:10 +0100 |
| |
Improve readability by moving the assignment out of if conditions.
Co-developed-by: Lukas Panzer <lukas.panzer@fau.de> Signed-off-by: Lukas Panzer <lukas.panzer@fau.de> Signed-off-by: Simon Geis <simon.geis@fau.de>
--- drivers/pcmcia/i82092.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/pcmcia/i82092.c b/drivers/pcmcia/i82092.c index 6b39750db282..ad105f9949c7 100644 --- a/drivers/pcmcia/i82092.c +++ b/drivers/pcmcia/i82092.c @@ -77,7 +77,8 @@ static int i82092aa_pci_probe(struct pci_dev *dev, const struct pci_device_id *i enter("i82092aa_pci_probe"); - if ((ret = pci_enable_device(dev))) + ret = pci_enable_device(dev); + if (ret) return ret; pci_read_config_byte(dev, 0x40, &configbyte); /* PCI Configuration Control */ @@ -133,7 +134,9 @@ static int i82092aa_pci_probe(struct pci_dev *dev, const struct pci_device_id *i /* Register the interrupt handler */ dev_dbg(&dev->dev, "Requesting interrupt %i\n", dev->irq); - if ((ret = request_irq(dev->irq, i82092aa_interrupt, IRQF_SHARED, "i82092aa", i82092aa_interrupt))) { + ret = request_irq(dev->irq, i82092aa_interrupt, IRQF_SHARED, + "i82092aa", i82092aa_interrupt); + if (ret) { dev_err(&dev->dev, "Failed to register IRQ %d, aborting\n", dev->irq); goto err_out_free_res; -- 2.20.1
|  |