[lkml]   [2019]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] spi: bcm2835: don't print error on clk_get() DEFER
On Thu, Dec 12, 2019 at 06:12:13PM -0500, Jim Quinlan wrote:
> Otherwise one may get multiple error messages for normal
> operation of a clock provider.

> if (IS_ERR(bs->clk)) {
> err = PTR_ERR(bs->clk);
> - dev_err(&pdev->dev, "could not get clk: %d\n", err);
> + if (err != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "could not get clk: %d\n", err);

On the other hand if the clock isn't there and never appears then there
won't be anything saying why the driver isn't loading which won't be
helpful when trying to figure out what's going on.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2019-12-13 12:42    [W:0.078 / U:0.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site