lkml.org 
[lkml]   [2019]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] bluetooth: hci_bcm: enable IRQ capability from node
On Thu, Dec 12, 2019 at 09:46:32PM +0100, Marcel Holtmann wrote:
> Hi Nicolas,
>
> >> Actually IRQ can be found from GPIO but all platforms don't support
> >> gpiod_to_irq, it's the case on amlogic chip.
> >> so to have possibility to use interrupt mode we need to add interrupts
> >> field in node and support it in driver.
> >>
> >> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> >> ---
> >> drivers/bluetooth/hci_bcm.c | 3 +++
> >> 1 file changed, 3 insertions(+)
> >
> > This triggers the following panic on Raspberry Pi 4:
> >
> > [ 6.634507] Unable to handle kernel NULL pointer dereference at virtual
> > address 0000000000000018

> >> diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
> >> index f8f5c593a05c..9f52d57c56de 100644
> >> --- a/drivers/bluetooth/hci_bcm.c
> >> +++ b/drivers/bluetooth/hci_bcm.c
> >> @@ -1409,6 +1409,7 @@ static int bcm_serdev_probe(struct serdev_device
> >> *serdev)
> >> {
> >> struct bcm_device *bcmdev;
> >> const struct bcm_device_data *data;
> >> + struct platform_device *pdev;
> >> int err;
> >>
> >> bcmdev = devm_kzalloc(&serdev->dev, sizeof(*bcmdev), GFP_KERNEL);
> >> @@ -1421,6 +1422,8 @@ static int bcm_serdev_probe(struct serdev_device
> >> *serdev)
> >> #endif
> >> bcmdev->serdev_hu.serdev = serdev;
> >> serdev_device_set_drvdata(serdev, bcmdev);
> >> + pdev = to_platform_device(bcmdev->dev);
> >
> > Ultimately bcmdev->dev here comes from a serdev device not a platform device,
> > right?
>
> I was afraid of this, but then nobody spoke up. Can we fix this or
> should I just revert the patch?

Just revert it, the patch is plain broken and makes no sense.

As Nicolas pointed out, bcmdev->dev is a member of struct serdev_device
so cannot be cast to a platform device.

Johan

\
 
 \ /
  Last update: 2019-12-13 10:18    [W:0.044 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site