lkml.org 
[lkml]   [2019]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subjectre: drm/i915: Use the i915_device name for identifying our, request fences
Date
Hi,

Static analysis with Coverity has picked up an issue with the following
commit:

commit 65c29dbb19b2451990c5c477fef7ada3b8218f05
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Wed Dec 11 15:02:04 2019 +0000

drm/i915: Use the i915_device name for identifying our request fences

In source drivers/gpu/drm/i915/i915_request.c and function
i915_fence_get_timeline_name there is the following:

return to_request(fence)->gem_context->name ?: "[" DRIVER_NAME "]";

However name is an array: char name[TASK_COMM_LEN + 8], so it can never
be null, so the ternary operator will always return name and will never
reaturn "[" DRIVER_NAME "]". Should it instead be checking if name[0]
is '\0' instead?

Colin

\
 
 \ /
  Last update: 2019-12-12 20:55    [W:0.041 / U:4.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site