lkml.org 
[lkml]   [2019]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement
From
From: Scott Schafer <schaferjscott@gmail.com>
Date: Thu, 12 Dec 2019 09:02:00 -0600

> On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote:
>> On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote:
>> > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct mbox_params *mbcp)
>> > mbcp->out_count = 6;
>> >
>> > status = ql_get_mb_sts(qdev, mbcp);
>> > - if (status)
>> > + if (status) {
>> > netif_err(qdev, drv, qdev->ndev, "Lost AEN broken!\n");
>> > + }
>> > else {
>>
>> The close } should be on the same line as the else.
>>
>> > int i;
>> >
>>
>> regards,
>> dan carpenter
>
> this was fixed in patch 22

It should not be introduced in the first place. Therefore it needs to be dealt with
in this patch.

\
 
 \ /
  Last update: 2019-12-12 20:25    [W:0.050 / U:43.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site