lkml.org 
[lkml]   [2019]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.19 185/243] ARM: dts: sun8i: a23/a33: Fix up RTC device node
On Thu, Dec 12, 2019 at 10:18:34PM +0800, Chen-Yu Tsai wrote:
> On Thu, Dec 12, 2019 at 10:02 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Dec 12, 2019 at 02:31:32PM +0100, Pavel Machek wrote:
> > > Hi!
> > >
> > > > The RTC module on the A23 was claimed to be the same as on the A31, when
> > > > in fact it is not. The A31 does not have an RTC external clock output,
> > > > and its internal RC oscillator's average clock rate is not in the same
> > > > range. The A33's RTC is the same as the A23.
> > > >
> > > > This patch fixes the compatible string and clock properties to conform
> > > > to the updated bindings. The register range is also fixed.
> > >
> > > No, this is not okay for v4.19. New compatible is not in
> > > ./drivers/rtc/rtc-sun6i.c, so this will completely break rtc support.
> >
> > Good catch, I would have thought both of those would happen at the same
> > time.
>
> (Fixed Maxime's email)
>
> Neither were marked for stable. I guess Sasha's auto selection bot is at
> work here. Is there anything we can do to prevent them from being selected?
> For sunxi, we pretty much don't expect things to be backported, unless
> something critical was fixed.

Sasha can add any files to the bot to ignore, just let him know what
ones to mark that way.

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-12-12 17:11    [W:0.121 / U:17.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site