lkml.org 
[lkml]   [2019]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 20/23] staging: qlge: Fix CHECK: usleep_range is preferred over udelay
From
Date
Hello!

On 11.12.2019 21:12, Scott Schafer wrote:

> chage udelay() to usleep_range()

Change?

> Signed-off-by: Scott Schafer <schaferjscott@gmail.com>
> ---
> drivers/staging/qlge/qlge_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> index e18aa335c899..9427386e4a1e 100644
> --- a/drivers/staging/qlge/qlge_main.c
> +++ b/drivers/staging/qlge/qlge_main.c
> @@ -147,7 +147,7 @@ int ql_sem_spinlock(struct ql_adapter *qdev, u32 sem_mask)
> do {
> if (!ql_sem_trylock(qdev, sem_mask))
> return 0;
> - udelay(100);
> + usleep_range(100, 200);

I hope you're not in atomic context...

> } while (--wait_count);
> return -ETIMEDOUT;
> }

MBR, Sergei

\
 
 \ /
  Last update: 2019-12-12 11:46    [W:0.144 / U:12.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site