lkml.org 
[lkml]   [2019]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/6] mfd: rn5t618: add irq support
On Wed, 11 Dec 2019 07:50:21 +0000
Lee Jones <lee.jones@linaro.org> wrote:

[...]
> > > > +
> > > > static const struct i2c_device_id rn5t618_i2c_id[] = {
> > > > { }
> > > > };
> > > > MODULE_DEVICE_TABLE(i2c, rn5t618_i2c_id);
> > >
> > > Not this patch I know, but it's strange to see this empty.
> >
> > Yes, should be cleaned up. For now the device tree stuff seems to kick in.
>
> I think this can be removed completely.
>
> Just make sure you use .probe2 and it should be automatic.
>
Hmm, I cannot find probe2 but probe_new. So you mean probe_new?

I will send a separate cleanup patch

Regards,
Andreas
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-12-11 12:44    [W:0.036 / U:4.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site