lkml.org 
[lkml]   [2019]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 15/24] compat_ioctl: scsi: move ioctl handling into drivers
From
Date
On 12/12/19 00:05, Michael S. Tsirkin wrote:
>> @@ -405,6 +405,9 @@ static int virtblk_getgeo(struct block_device *bd, struct hd_geometry *geo)
>>
>> static const struct block_device_operations virtblk_fops = {
>> .ioctl = virtblk_ioctl,
>> +#ifdef CONFIG_COMPAT
>> + .compat_ioctl = blkdev_compat_ptr_ioctl,
>> +#endif
>> .owner = THIS_MODULE,
>> .getgeo = virtblk_getgeo,
>> };
> Hmm - is virtio blk lumped in with scsi things intentionally?

I think it's because the only ioctl for virtio-blk is SG_IO. It makes
sense to lump it in with scsi, but I wouldn't mind getting rid of
CONFIG_VIRTIO_BLK_SCSI altogether.

Paolo

\
 
 \ /
  Last update: 2019-12-12 01:28    [W:0.069 / U:16.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site