lkml.org 
[lkml]   [2019]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 6/6] rtc: rtc-rc5t619: add ricoh rc5t619 RTC driver
On 11/12/2019 20:33:21+0100, Andreas Kemnade wrote:
> Hi,
>
> On Mon, 2 Dec 2019 10:39:35 +0100
> Alexandre Belloni <alexandre.belloni@bootlin.com> wrote:
>
> > On 29/11/2019 22:20:45+0100, Andreas Kemnade wrote:
> > > Add an RTC driver for the RTC device on Ricoh MFD rc5t619,
> > > which is implemented as a variant of rn5t618.
> > >
> will capitalize chip names in the commit text as requested for the other
> patches by Lee.
>
> > > rtc-range output:
> > > Testing 2000-02-28 23:59:59.
> > > OK
> > >
> > > Testing 2038-01-19 03:14:07.
> > > OK
> > >
> > > Testing 2069-12-31 23:59:59.
> > > OK
> > >
> > > Testing 2099-12-31 23:59:59.
> > > KO RTC_RD_TIME returned 22 (line 138)
> > >
> > > Testing 2100-02-28 23:59:59.
> > > KO RTC_SET_TIME returned 34 (line 122)
> > >
> > > Testing 2106-02-07 06:28:15.
> > > KO RTC_SET_TIME returned 34 (line 122)
> > >
> > > Testing 2262-04-11 23:47:16.
> > > KO RTC_SET_TIME returned 34 (line 122)
> > >
> > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> >
> I will remove
> static int rc5t619_rtc_alarm_is_enabled(struct device *dev, uint8_t *enabled)
>
> since it is unused now so gcc emits a warning, which I have overlooked.
> I hope your Acked-by still counts for that.
>

Sure, you can keep it.

While at it, the subject should be:

rtc: rc5t619: add ricoh rc5t619 RTC driver

If you want, you can capitalize the second rc5t619 but not the first
one.


--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

\
 
 \ /
  Last update: 2019-12-11 21:18    [W:0.040 / U:7.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site