lkml.org 
[lkml]   [2019]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 07/15] firmware: arm_scmi: Stash version in protocol init functions
From
Date
On 10/12/2019 14:53, Sudeep Holla wrote:
> In order to avoid querying the individual protocol versions multiple
> time with more that one device created for each protocol, we can simple
> store the copy in the protocol specific private data and use them whenever
> required.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/firmware/arm_scmi/clock.c | 2 ++
> drivers/firmware/arm_scmi/perf.c | 2 ++
> drivers/firmware/arm_scmi/power.c | 2 ++
> drivers/firmware/arm_scmi/reset.c | 2 ++
> drivers/firmware/arm_scmi/sensors.c | 2 ++
> 5 files changed, 10 insertions(+)
>

LGTM.

Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>


Cristian



> diff --git a/drivers/firmware/arm_scmi/clock.c b/drivers/firmware/arm_scmi/clock.c
> index 6c24eb8a4e68..b567ec03f711 100644
> --- a/drivers/firmware/arm_scmi/clock.c
> +++ b/drivers/firmware/arm_scmi/clock.c
> @@ -65,6 +65,7 @@ struct scmi_clock_set_rate {
> };
>
> struct clock_info {
> + u32 version;
> int num_clocks;
> int max_async_req;
> atomic_t cur_async_req;
> @@ -344,6 +345,7 @@ static int scmi_clock_protocol_init(struct scmi_device *dev)
> scmi_clock_describe_rates_get(handle, clkid, clk);
> }
>
> + cinfo->version = version;
> handle->clk_ops = &clk_ops;
> handle->clk_priv = cinfo;
>
> diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
> index 4f02bfba98ba..b1de6197f61c 100644
> --- a/drivers/firmware/arm_scmi/perf.c
> +++ b/drivers/firmware/arm_scmi/perf.c
> @@ -145,6 +145,7 @@ struct perf_dom_info {
> };
>
> struct scmi_perf_info {
> + u32 version;
> int num_domains;
> bool power_scale_mw;
> u64 stats_addr;
> @@ -740,6 +741,7 @@ static int scmi_perf_protocol_init(struct scmi_device *dev)
> scmi_perf_domain_init_fc(handle, domain, &dom->fc_info);
> }
>
> + pinfo->version = version;
> handle->perf_ops = &perf_ops;
> handle->perf_priv = pinfo;
>
> diff --git a/drivers/firmware/arm_scmi/power.c b/drivers/firmware/arm_scmi/power.c
> index 5a8faa369d82..d11c6cd6bbab 100644
> --- a/drivers/firmware/arm_scmi/power.c
> +++ b/drivers/firmware/arm_scmi/power.c
> @@ -50,6 +50,7 @@ struct power_dom_info {
> };
>
> struct scmi_power_info {
> + u32 version;
> int num_domains;
> u64 stats_addr;
> u32 stats_size;
> @@ -211,6 +212,7 @@ static int scmi_power_protocol_init(struct scmi_device *dev)
> scmi_power_domain_attributes_get(handle, domain, dom);
> }
>
> + pinfo->version = version;
> handle->power_ops = &power_ops;
> handle->power_priv = pinfo;
>
> diff --git a/drivers/firmware/arm_scmi/reset.c b/drivers/firmware/arm_scmi/reset.c
> index 438d74a2c80a..dce103781b3f 100644
> --- a/drivers/firmware/arm_scmi/reset.c
> +++ b/drivers/firmware/arm_scmi/reset.c
> @@ -48,6 +48,7 @@ struct reset_dom_info {
> };
>
> struct scmi_reset_info {
> + u32 version;
> int num_domains;
> struct reset_dom_info *dom_info;
> };
> @@ -221,6 +222,7 @@ static int scmi_reset_protocol_init(struct scmi_device *dev)
> scmi_reset_domain_attributes_get(handle, domain, dom);
> }
>
> + pinfo->version = version;
> handle->reset_ops = &reset_ops;
> handle->reset_priv = pinfo;
>
> diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c
> index afa51bedfa5d..aac0243e2880 100644
> --- a/drivers/firmware/arm_scmi/sensors.c
> +++ b/drivers/firmware/arm_scmi/sensors.c
> @@ -68,6 +68,7 @@ struct scmi_msg_sensor_reading_get {
> };
>
> struct sensors_info {
> + u32 version;
> int num_sensors;
> int max_requests;
> u64 reg_addr;
> @@ -298,6 +299,7 @@ static int scmi_sensors_protocol_init(struct scmi_device *dev)
>
> scmi_sensor_description_get(handle, sinfo);
>
> + sinfo->version = version;
> handle->sensor_ops = &sensor_ops;
> handle->sensor_priv = sinfo;
>
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2019-12-11 18:36    [W:0.085 / U:3.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site