lkml.org 
[lkml]   [2019]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] gpio: gpio-mockup: Fix usage of new GPIO_LINE_DIRECTION
śr., 11 gru 2019 o 01:46 Kent Gibson <warthog618@gmail.com> napisał(a):
>
> Restore the external behavior of gpio-mockup to what it was prior to the
> change to using GPIO_LINE_DIRECTION.
>
> Fixes: e42615ec233b ("gpio: Use new GPIO_LINE_DIRECTION")
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> ---
>
> Changes v1 -> v2:
> - add Fixes tag.
>
> Fix a regression introduced in v5.5-rc1.
>
> The change to GPIO_LINE_DIRECTION reversed the polarity of the
> dir field within gpio-mockup.c, but overlooked inverting the value on
> initialization and when returned by gpio_mockup_get_direction.
> The latter is a bug.
> The former is a problem for tests which assume initial conditions,
> specifically the mockup used to initialize chips with all lines as inputs.
> That superficially appeared to be the case after the previous patch due
> to the bug in gpio_mockup_get_direction.
>
> drivers/gpio/gpio-mockup.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>

Applied for fixes.

Thanks!
Bartosz

\
 
 \ /
  Last update: 2019-12-11 10:01    [W:0.022 / U:3.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site