lkml.org 
[lkml]   [2019]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC 0/8] Add Unisoc's drm kms module
Hi Kevin.

Thanks for this new driver.
A few somments triggered alone from the diffstat.
> Kevin Tang (8):
> dt-bindings: display: add Unisoc's drm master bindings
> drm/sprd: add Unisoc's drm kms master
> dt-bindings: display: add Unisoc's dpu bindings
> drm/sprd: add Unisoc's drm display controller driver
> dt-bindings: display: add Unisoc's mipi dsi&dphy bindings
> drm/sprd: add Unisoc's drm mipi dsi&dphy driver
> dt-bindings: display: add Unisoc's generic mipi panel bindings
> drm/sprd: add Unisoc's drm generic mipi panel driver
>
> .../devicetree/bindings/display/sprd/dphy.txt | 49 +
> .../devicetree/bindings/display/sprd/dpu.txt | 55 +
> .../devicetree/bindings/display/sprd/drm.txt | 18 +
> .../devicetree/bindings/display/sprd/dsi.txt | 68 +
> .../devicetree/bindings/display/sprd/panel.txt | 110 ++

New bindings in metaschema format (.yaml).
And panel bindings in display/panel/

> drivers/gpu/drm/Kconfig | 2 +
> drivers/gpu/drm/Makefile | 1 +
> drivers/gpu/drm/sprd/Kconfig | 14 +
> drivers/gpu/drm/sprd/Makefile | 17 +
> drivers/gpu/drm/sprd/disp_lib.c | 290 ++++
> drivers/gpu/drm/sprd/disp_lib.h | 40 +
> drivers/gpu/drm/sprd/dphy/Makefile | 7 +
> drivers/gpu/drm/sprd/dphy/pll/Makefile | 3 +
> drivers/gpu/drm/sprd/dphy/pll/megacores_sharkle.c | 640 +++++++++
> drivers/gpu/drm/sprd/dphy/sprd_dphy_api.c | 254 ++++
> drivers/gpu/drm/sprd/dphy/sprd_dphy_hal.h | 329 +++++
> drivers/gpu/drm/sprd/dpu/Makefile | 8 +
> drivers/gpu/drm/sprd/dpu/dpu_r2p0.c | 1464 ++++++++++++++++++++
> drivers/gpu/drm/sprd/dsi/Makefile | 7 +
> drivers/gpu/drm/sprd/dsi/core/Makefile | 3 +
> drivers/gpu/drm/sprd/dsi/core/dsi_ctrl_r1p0.c | 1186 ++++++++++++++++
> drivers/gpu/drm/sprd/dsi/core/dsi_ctrl_r1p0.h | 1417 +++++++++++++++++++
> drivers/gpu/drm/sprd/dsi/core/dsi_ctrl_r1p0_ppi.c | 392 ++++++
> drivers/gpu/drm/sprd/dsi/sprd_dsi_api.c | 544 ++++++++
> drivers/gpu/drm/sprd/dsi/sprd_dsi_api.h | 28 +
> drivers/gpu/drm/sprd/dsi/sprd_dsi_hal.h | 1102 +++++++++++++++
> drivers/gpu/drm/sprd/sprd_dphy.c | 235 ++++
> drivers/gpu/drm/sprd/sprd_dphy.h | 121 ++
> drivers/gpu/drm/sprd/sprd_dpu.c | 1152 +++++++++++++++
> drivers/gpu/drm/sprd/sprd_dpu.h | 217 +++
> drivers/gpu/drm/sprd/sprd_drm.c | 287 ++++
> drivers/gpu/drm/sprd/sprd_drm.h | 19 +
> drivers/gpu/drm/sprd/sprd_dsi.c | 722 ++++++++++
> drivers/gpu/drm/sprd/sprd_dsi.h | 210 +++
> drivers/gpu/drm/sprd/sprd_gem.c | 178 +++
> drivers/gpu/drm/sprd/sprd_gem.h | 30 +

> drivers/gpu/drm/sprd/sprd_panel.c | 778 +++++++++++
> drivers/gpu/drm/sprd/sprd_panel.h | 114 ++
Please move panels to drivers/gpu/drm/panel/ and make sure to utilize
the drm_panel infrastructure.

Sam

\
 
 \ /
  Last update: 2019-12-10 19:55    [W:0.105 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site