lkml.org 
[lkml]   [2019]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V2] lib/dynamic_debug: make better dynamic log output
From
Date


On 12/10/19 1:38 AM, Huang Shijie wrote:
> The driver strings and device name is not changed for the driver's dynamic
> log output. But the dynamic_emit_prefix() which contains the function names
> may change when the function names change.
>
> So the patch makes the better dynamic log output.
>
> Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai>
> ---
> v1 -- >v2
> Add a whitespace between driver strings and dev name.
> ---
> lib/dynamic_debug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index c60409138e13..f6665af6abd4 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -589,9 +589,9 @@ void __dynamic_dev_dbg(struct _ddebug *descriptor,
> } else {
> char buf[PREFIX_SIZE];
>
> - dev_printk_emit(LOGLEVEL_DEBUG, dev, "%s%s %s: %pV",
> - dynamic_emit_prefix(descriptor, buf),
> + dev_printk_emit(LOGLEVEL_DEBUG, dev, "%s %s %s: %pV",
> dev_driver_string(dev), dev_name(dev),
> + dynamic_emit_prefix(descriptor, buf),
> &vaf);
> }
>
>


Hi Huang,

So this is just reversing the order of output. All the other dynamic
debug calls emit the 'prefix' first, so if we were to change this it
seems like we'd also want to change the other ones to be consistent.

That said, I'm not sure why reversing things here is better?

Thanks,

-Jason

\
 
 \ /
  Last update: 2019-12-10 19:17    [W:0.045 / U:9.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site