lkml.org 
[lkml]   [2019]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v6 05/13] exfat: add file operations
Date

> > + /* Of the r and x bits, all (subject to umask) must be
> > present.*/
> > + if ((perm & 0555) != (i_mode & 0555))
I modified it due to warnning alarm from checkpatch.pl.
Other octal permissions are same reason.
WARNING: Symbolic permissions 'S_IRUGO | S_IXUGO' are not preferred. Consider using octal permissions '0555'.
+ if ((perm & (S_IRUGO | S_IXUGO)) != (i_mode & (S_IRUGO | S_IXUGO)))

> > + /* update the directory entry */
> > + if (!evict) {
> > + es = exfat_get_dentry_set(sb, &(ei->dir), ei->entry,
> > + ES_ALL_ENTRIES, &ep);
> > + if (!es)
> > + return -EIO;
> > + ep2 = ep + 1;
>
> The ep2 could point out on the garbage here. Maybe, it makes sense to
> add some check here?
Could you please elaborate more? How could ep2 be the garbage?
I want you to check exfat_get_dentry_set().

Thanks for your review!

\
 
 \ /
  Last update: 2019-12-11 02:01    [W:0.045 / U:5.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site