[lkml]   [2019]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH AUTOSEL 5.4 306/350] selftests, bpf: Fix test_tc_tunnel hanging
From: Jiri Benc <>

[ Upstream commit 3b054b7133b4ad93671c82e8d6185258e3f1a7a5 ]

When is run, it hangs after The reason
is ensures the server ('nc -l') is run all the time,
starting it again every time it is expected to terminate. The exception is
the final client_connect: the server is not started anymore, which ensures
no process is kept running after the test is finished.

For a sit test, though, the script is terminated prematurely without the
final client_connect and the 'nc' process keeps running. This in turn causes
the run_one function in kselftest/ to hang forever, waiting for the
runaway process to finish.

Ensure a remaining server is terminated on cleanup.

Fixes: f6ad6accaa99 ("selftests/bpf: expand test_tc_tunnel with SIT encap")
Signed-off-by: Jiri Benc <>
Signed-off-by: Daniel Borkmann <>
Acked-by: Willem de Bruijn <>
Signed-off-by: Sasha Levin <>
tools/testing/selftests/bpf/ | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/tools/testing/selftests/bpf/ b/tools/testing/selftests/bpf/
index ff0d31d38061f..7c76b841b17bb 100755
--- a/tools/testing/selftests/bpf/
+++ b/tools/testing/selftests/bpf/
@@ -62,6 +62,10 @@ cleanup() {
if [[ -f "${infile}" ]]; then
rm "${infile}"
+ if [[ -n $server_pid ]]; then
+ kill $server_pid 2> /dev/null
+ fi

server_listen() {
@@ -77,6 +81,7 @@ client_connect() {

verify_data() {
wait "${server_pid}"
+ server_pid=
# sha1sum returns two fields [sha1] [filepath]
# convert to bash array and access first elem
insum=($(sha1sum ${infile}))
 \ /
  Last update: 2019-12-10 22:13    [W:2.041 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site