Messages in this thread |  | | Date | Mon, 02 Dec 2019 13:30:04 +1030 | From | "Andrew Jeffery" <> | Subject | Re: [PATCH v3 2/6] gpio: make gpiod to offset() available for other users |
| |
On Sat, 30 Nov 2019, at 03:55, Marco Felsch wrote: > Currently gpiod_to_offset() is a gpio-subsystem private function which > is used by the gpiolib itself and by the aspeed gpio driver. The time > has shown that there are other drivers as well which need this > information in some special cases e.g. MFD drivers. The patch makes the > function public but you need to explicit add the <linux/gpio/private.h> > include. See discussion [1] for more information. > > [1] https://lkml.org/lkml/2019/11/27/357 > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > v3: > - former patch description was "gpio: add support to get local gpio number" > - adapt commit message and description to reflect new state > - don't add wrapper instead use the already existing gpiod_to_offset > - move gpiod_to_offset from gpiolib.h into gpiolib.c > - move declaration into linux/gpio/private.h > --- > drivers/gpio/gpio-aspeed.c | 11 +++++------
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
|  |