lkml.org 
[lkml]   [2019]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 014/109] RDMA/i40iw: Fix incorrect iterator type
    Date
    From: Håkon Bugge <Haakon.Bugge@oracle.com>

    [ Upstream commit 802fa45cd320de319e86c93bca72abec028ba059 ]

    Commit f27b4746f378 ("i40iw: add connection management code") uses an
    incorrect rcu iterator, whilst holding the rtnl_lock. Since the
    critical region invokes i40iw_manage_qhash(), which is a sleeping
    function, the rcu locking and traversal cannot be used.

    Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/i40iw/i40iw_cm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c
    index b7f1ce5333cb8..880c63579ba88 100644
    --- a/drivers/infiniband/hw/i40iw/i40iw_cm.c
    +++ b/drivers/infiniband/hw/i40iw/i40iw_cm.c
    @@ -1667,7 +1667,7 @@ static enum i40iw_status_code i40iw_add_mqh_6(struct i40iw_device *iwdev,
    unsigned long flags;

    rtnl_lock();
    - for_each_netdev_rcu(&init_net, ip_dev) {
    + for_each_netdev(&init_net, ip_dev) {
    if ((((rdma_vlan_dev_vlan_id(ip_dev) < I40IW_NO_VLAN) &&
    (rdma_vlan_dev_real_dev(ip_dev) == iwdev->netdev)) ||
    (ip_dev == iwdev->netdev)) && (ip_dev->flags & IFF_UP)) {
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-11-10 03:46    [W:2.518 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site