lkml.org 
[lkml]   [2019]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v2 0/5] drm/komeda: Improve IRQ error event prints
Date
Hi everyone,

Sending out a v2 of the series since I had missed out a couple of issues
checkpatch caught.

Changes since v1 [https://patchwork.freedesktop.org/series/68325/]:
- Fixed a couple of checkpatch issues in 2/5 and 5/5

v1's cover letter:

This is a smallish series that tries to remove some build-time
configurability in komeda and replace it with a debugfs control. Later
patches in the series add some extra functionality which I found useful
during my debugging sessions, so I figured I'd bake it in.

I've preserved the default behaviour as if CONFIG_KOMEDA_ERROR_PRINT
were enabled, so production kernels can have some feedback from the
driver when things are going south.

1: Introduce the err_verbosity debugfs node for komeda; this keeps the
default of printing error events once per frame.
2: Drop CONFIG_KOMEDA_ERROR_PRINT since output can be disabled at
runtime
3: Add a drm state dump on event. It's quite chatty so I left it only
for error events; printing all that once per frame every vsync floods my
serial terminal, so no info + state combination.
4: Add lower-severity categories to the event printer
5: Normally these events fire only once per pageflip, but sometimes it's
useful to see them all as they come in.

These patches are overall quite tiny, and I was considering just
squashing them into one, but I opted to keep them separate for an easier
review experience; please let me know whether you prefer a single patch.
Thanks!

Mihail Atanassov (5):
drm/komeda: Add debugfs node to control error verbosity
drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT
drm/komeda: Optionally dump DRM state on interrupts
drm/komeda: Add option to print WARN- and INFO-level IRQ events
drm/komeda: add rate limiting disable to err_verbosity

drivers/gpu/drm/arm/display/Kconfig | 6 ----
drivers/gpu/drm/arm/display/komeda/Makefile | 5 ++--
.../gpu/drm/arm/display/komeda/komeda_dev.c | 4 +++
.../gpu/drm/arm/display/komeda/komeda_dev.h | 30 +++++++++++++++----
.../gpu/drm/arm/display/komeda/komeda_event.c | 23 +++++++++++---
.../gpu/drm/arm/display/komeda/komeda_kms.c | 2 +-
6 files changed, 51 insertions(+), 19 deletions(-)

--
2.23.0

\
 
 \ /
  Last update: 2019-11-07 12:42    [W:0.145 / U:6.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site