[lkml]   [2019]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v5 11/14] arm64: efi: restore x18 if it was corrupted
On Wed, 6 Nov 2019 at 05:46, Miguel Ojeda
<> wrote:
> On Wed, Nov 6, 2019 at 12:56 AM Sami Tolvanen <> wrote:
> >
> > If we detect a corrupted x18 and SCS is enabled, restore the register
> > before jumping back to instrumented code. This is safe, because the
> > wrapper is called with preemption disabled and a separate shadow stack
> > is used for interrupt handling.
> In case you do v6: I think putting the explanation about why this is
> safe in the existing comment would be best given it is justifying a
> subtlety of the code rather than the change itself. Ard?

Agreed, but only if you have to respin for other reasons.

 \ /
  Last update: 2019-11-07 11:52    [W:0.252 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site