Messages in this thread |  | | From | Sami Tolvanen <> | Date | Mon, 4 Nov 2019 13:38:30 -0800 | Subject | Re: [PATCH v4 13/17] arm64: preserve x18 when CPU is suspended |
| |
On Mon, Nov 4, 2019 at 5:20 AM Marc Zyngier <maz@kernel.org> wrote: > > ENTRY(cpu_do_suspend) > > mrs x2, tpidr_el0 > > @@ -73,6 +75,9 @@ alternative_endif > > stp x8, x9, [x0, #48] > > stp x10, x11, [x0, #64] > > stp x12, x13, [x0, #80] > > +#ifdef CONFIG_SHADOW_CALL_STACK > > + str x18, [x0, #96] > > +#endif > > Do we need the #ifdefery here? We didn't add that to the KVM path, > and I'd feel better having a single behaviour, specially when > NR_CTX_REGS is unconditionally sized to hold 13 regs.
I'm fine with dropping the ifdefs here in v5 unless someone objects to this.
Sami
|  |