[lkml]   [2019]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 03/17] arm64: kvm: stop treating register x18 as caller save
On 2019-11-04 12:13, Marc Zyngier wrote:
> Hi Sami,
> On 2019-11-01 23:20, Sami Tolvanen wrote:
>> From: Ard Biesheuvel <>
>> In preparation of reserving x18, stop treating it as caller save in
>> the KVM guest entry/exit code. Currently, the code assumes there is
>> no need to preserve it for the host, given that it would have been
>> assumed clobbered anyway by the function call to __guest_enter().
>> Instead, preserve its value and restore it upon return.
>> Link:
>> Signed-off-by: Ard Biesheuvel <>
>> [Sami: updated commit message, switched from x18 to x29 for the
>> guest
>> context]
>> Signed-off-by: Sami Tolvanen <>
>> Reviewed-by: Kees Cook <>
> If you intend for this to be merged via the arm64 tree, please add my
> Reviewed-by: Marc Zyngier <>

Erm... Muscle memory strikes again. Please ignore the above and use the
following instead:

Reviewed-by: Marc Zyngier <>


Jazz is not dead. It just smells funny...

 \ /
  Last update: 2019-11-04 14:30    [W:0.193 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site