Messages in this thread |  | | Date | Sat, 30 Nov 2019 19:39:29 +0530 | From | Manivannan Sadhasivam <> | Subject | Re: [PATCH 3/5] media: i2c: imx290: Add RAW12 mode support |
| |
Hi Fabio,
On Fri, Nov 29, 2019 at 04:49:25PM -0300, Fabio Estevam wrote: > Hi Manivannan, > > On Fri, Nov 29, 2019 at 4:07 PM Manivannan Sadhasivam > <manivannan.sadhasivam@linaro.org> wrote: > } > > + > > + imx290->bpp = 10; > > + > > + break; > > + case MEDIA_BUS_FMT_SRGGB12_1X12: > > + ret = imx290_set_register_array(imx290, imx290_12bit_settings, > > + ARRAY_SIZE( > > + imx290_12bit_settings)); > > Could you please write the ARRAY_SIZE and its parameter in the same line? > > It would improve readability. >
I don't favor this change but Sakari did this to supress the checkpatch warning while applying my initial patch, so now I did this here itself to maintain the uniformity.
Thanks, Mani
> Thanks
|  |