lkml.org 
[lkml]   [2019]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.19 185/306] net: hns3: bugfix for buffer not free problem during resetting
Hi!

> > > From: Huazhong Tan <tanhuazhong@huawei.com>
> > >
> > > [ Upstream commit 73b907a083b8a8c1c62cb494bc9fbe6ae086c460 ]
> > >
> > > When hns3_get_ring_config()/hns3_queue_to_ring()/
> > > hns3_get_vector_ring_chain() failed during resetting, the allocated
> > > memory has not been freed before these three functions return. So
> > > this patch adds error handler in these functions to fix it.
> >
> > Correct me if I'm wrong, but... this introduces use-after-free:
> > Should it do devm_kfree(&pdev->dev, cur_chain); ?
>
> I think Sasha tried to backport a fix for this patch, but that fix broke
> the build :(
>
> If you want to provide a working backport, I'll be glad to take it.

Actually it looks like problem originated in mainline, and there was
more than one problem with this patch.

cda69d244585bc4497d3bb878c22fe2b6ad647c1 should fix it; it needs to be
back-ported, too.

Best regards,
Pavel

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-11-29 23:24    [W:0.313 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site