[lkml]   [2019]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 4.19 026/306] pinctrl: madera: Fix uninitialized variable bug in madera_mux_set_mux
    From: Gustavo A. R. Silva <>

    [ Upstream commit 4fe81669df50889ff1072c030c59df5f1fa6534e ]

    There is a potential execution path in which variable *ret* is checked
    in an IF statement, and then its value is used to report an error at
    line 659 without being properly initialized previously:

    659 if (ret)
    660 dev_err(priv->dev, "Failed to write to 0x%x (%d)\n", reg, ret);

    Fix this by initializing variable *ret* to 0 in order to
    avoid unpredictable or unintended results.

    Addresses-Coverity-ID: 1471969 ("Uninitialized scalar variable")
    Fixes: 218d72a77b0b ("pinctrl: madera: Add driver for Cirrus Logic Madera codecs")
    Signed-off-by: Gustavo A. R. Silva <>
    Acked-by: Charles Keepax <>
    Signed-off-by: Linus Walleij <>
    Signed-off-by: Sasha Levin <>
    drivers/pinctrl/cirrus/pinctrl-madera-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/pinctrl/cirrus/pinctrl-madera-core.c b/drivers/pinctrl/cirrus/pinctrl-madera-core.c
    index c4f4d904e4a61..618e04407ac85 100644
    --- a/drivers/pinctrl/cirrus/pinctrl-madera-core.c
    +++ b/drivers/pinctrl/cirrus/pinctrl-madera-core.c
    @@ -608,7 +608,7 @@ static int madera_mux_set_mux(struct pinctrl_dev *pctldev,
    unsigned int n_chip_groups = priv->chip->n_pin_groups;
    const char *func_name = madera_mux_funcs[selector].name;
    unsigned int reg;
    - int i, ret;
    + int i, ret = 0;

    dev_dbg(priv->dev, "%s selecting %u (%s) for group %u (%s)\n",
    __func__, selector, func_name, group,

     \ /
      Last update: 2019-11-27 21:56    [W:4.098 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site