lkml.org 
[lkml]   [2019]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/8] platform/x86: asus-wmi: switch to use <linux/temperature.h> helpers
On Mon, Nov 25, 2019 at 4:32 PM Akinobu Mita <akinobu.mita@gmail.com> wrote:
> 2019年11月25日(月) 4:54 Andy Shevchenko <andy.shevchenko@gmail.com>:
> > On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita <akinobu.mita@gmail.com> wrote:

> > > - value = DECI_KELVIN_TO_CELSIUS((value & 0xFFFF)) * 1000;
> > > -
> > > - return sprintf(buf, "%d\n", value);
> >
> > > + return sprintf(buf, "%ld\n",
> > > + deci_kelvin_to_millicelsius(value & 0xFFFF));
> >
> > Leave it in one line.
>
> It causes this line over 80 characters.

And I don't care.

> Or do you prefer to save the
> conversion result in 'value' temporarily as before?

No.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2019-11-25 20:07    [W:0.062 / U:3.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site