lkml.org 
[lkml]   [2019]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH V4 3/4] rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support
Hi Arun,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.4-rc8 next-20191122]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Arun-Kumar-Neelakantam/rpmsg-core-Add-signal-API-support/20191124-174653
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 6b8a794678763130b7e7d049985008641dc494e8
config: riscv-defconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=riscv

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/rpmsg/rpmsg_char.c: In function 'rpmsg_eptdev_ioctl':
>> drivers/rpmsg/rpmsg_char.c:324:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
ret = rpmsg_eptdev_destroy(&eptdev->dev, NULL);
~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/rpmsg/rpmsg_char.c:325:2: note: here
default:
^~~~~~~

vim +324 drivers/rpmsg/rpmsg_char.c

305
306 static long rpmsg_eptdev_ioctl(struct file *fp, unsigned int cmd,
307 unsigned long arg)
308 {
309 struct rpmsg_eptdev *eptdev = fp->private_data;
310 int ret;
311
312 switch (cmd) {
313 case TIOCMGET:
314 ret = rpmsg_get_signals(eptdev->ept);
315 if (ret >= 0)
316 ret = put_user(ret, (int __user *)arg);
317 break;
318 case TIOCMSET:
319 case TIOCMBIS:
320 case TIOCMBIC:
321 ret = rpmsg_eptdev_tiocmset(fp, cmd, (int __user *)arg);
322 break;
323 case RPMSG_DESTROY_EPT_IOCTL:
> 324 ret = rpmsg_eptdev_destroy(&eptdev->dev, NULL);
325 default:
326 ret = -EINVAL;
327 }
328
329 return ret;
330 }
331

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2019-11-24 13:19    [W:0.030 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site