lkml.org 
[lkml]   [2019]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [v2 PATCH] PM / devfreq: Add new name attribute for sysfs
From
Date
Dear all,

Please ignore this patch because it has the my mistake.
I'll send v3 patch.

Best Regards,
Chanwoo Choi

On 11/25/19 9:47 AM, Chanwoo Choi wrote:
> The commit 4585fbcb5331 ("PM / devfreq: Modify the device name as devfreq(X) for
> sysfs") changed the node name to devfreq(x). After this commit, it is not
> possible to get the device name through /sys/class/devfreq/devfreq(X)/*.
>
> Add new name attribute in order to get device name.
>
> Cc: stable@vger.kernel.org
> Fixes: 4585fbcb5331 ("PM / devfreq: Modify the device name as devfreq(X) for sysfs")
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> Changes from v1:
> - Update sysfs-class-devfreq documentation
> - Show device name directly from 'devfreq->dev.parent'
>
> Documentation/ABI/testing/sysfs-class-devfreq | 7 +++++++
> drivers/devfreq/devfreq.c | 9 +++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-devfreq b/Documentation/ABI/testing/sysfs-class-devfreq
> index 01196e19afca..75897e2fde43 100644
> --- a/Documentation/ABI/testing/sysfs-class-devfreq
> +++ b/Documentation/ABI/testing/sysfs-class-devfreq
> @@ -7,6 +7,13 @@ Description:
> The name of devfreq object denoted as ... is same as the
> name of device using devfreq.
>
> +What: /sys/class/devfreq/.../name
> +Date: November 2019
> +Contact: Chanwoo Choi <cw00.choi@samsung.com>
> +Description:
> + The /sys/class/devfreq/.../name shows the name of device
> + of the corresponding devfreq object.
> +
> What: /sys/class/devfreq/.../governor
> Date: September 2011
> Contact: MyungJoo Ham <myungjoo.ham@samsung.com>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 61c3e2d08969..2e5f64ee1969 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -1476,7 +1476,16 @@ static ssize_t trans_stat_show(struct device *dev,
> }
> static DEVICE_ATTR_RO(trans_stat);
>
> +static ssize_t name_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct devfreq *devfreq = to_devfreq(dev);
> + return sprintf(buf, "%s\n", dev_name(devfreq->dev.parent));
> +}
> +static DEVICE_ATTR_RO(name);
> +
> static struct attribute *devfreq_attrs[] = {
> + &dev_attr_name.attr,
> &dev_attr_governor.attr,
> &dev_attr_available_governors.attr,
> &dev_attr_cur_freq.attr,
>


\
 
 \ /
  Last update: 2019-11-25 01:59    [W:0.033 / U:5.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site