lkml.org 
[lkml]   [2019]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [RFC PATCHv2 1/3] dt-bindings: misc: Add dt bindings for flex noc Performance Monitor
Date

Hi,

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Friday, October 11, 2019 3:19 AM
> To: Shubhrajyoti Datta <shubhraj@xilinx.com>
> Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org;
> arnd@arndb.de; gregkh@linuxfoundation.org; Michal Simek
> <michals@xilinx.com>
> Subject: Re: [RFC PATCHv2 1/3] dt-bindings: misc: Add dt bindings for flex noc
> Performance Monitor
>
> On Thu, Sep 26, 2019 at 10:46:24AM +0530, Shubhrajyoti Datta wrote:
> > Add dt bindings for flexnoc Performance Monitor.
> > The flexnoc counters for read and write response and requests are
> > supported.
> >
> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> > ---
> > .../devicetree/bindings/misc/xlnx,flexnoc.txt | 24
> ++++++++++++++++++++++
>
> bindings/perf/
>
> Please convert this to a schema. See
> Documentation/devicetree/writing-schema.rst.
Ok
>
> > 1 file changed, 24 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt
> >
> > diff --git a/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt
> > b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt
> > new file mode 100644
> > index 0000000..6b533bc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt
> > @@ -0,0 +1,24 @@
> > +* Xilinx Flexnoc Performance Monitor driver
>
> Bindings are for h/w blocks, not drivers.
Wil change
>
> > +
> > +The FlexNoc Performance Monitor has counters for monitoring the read
> > +and the write transaction counter.
> > +
> > +Required properties:
> > +- compatible: "xlnx,flexnoc-pm-2.7"
> > +- reg : Address and length of register sets for each device in
> > + "reg-names"
> > +- reg-names : The names of the register addresses corresponding to the
> > + registers filled in "reg"
> > + - funnel: base address of the funnel registers
> > + - baselpd: base address of the LPD PM registers
> > + - basefpd: base address FPD PM registers
>
> Is this really all one h/w block.
>
> FlexNoC is an interconnect, right? Is there more to it than just perfmon?
Yes , however the driver only uses the monitoring part.

>
> > +

\
 
 \ /
  Last update: 2019-11-21 10:04    [W:0.031 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site