lkml.org 
[lkml]   [2019]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 03/13] exfat: add inode operations
Date
> …
> > +++ b/fs/exfat/inode.c
> …
> > +static int exfat_create(struct inode *dir, struct dentry *dentry, umode_t
> mode,
> > + bool excl)
> > +{
> …
> +out:
> + mutex_unlock(&EXFAT_SB(sb)->s_lock);
>
> Can the label “unlock” be more appropriate?
Yep, Will change it.
>
>
> > +static struct dentry *exfat_lookup(struct inode *dir, struct dentry
> *dentry,
> > + unsigned int flags)
> > +{
> …
> > +error:
> > + mutex_unlock(&EXFAT_SB(sb)->s_lock);
>
> Would you like to use the label “unlock” also at this place (and similar
> ones)?
Yep, Will change all ones.

>
>
> > +static int exfat_search_empty_slot(struct super_block *sb,
> > + struct exfat_hint_femp *hint_femp, struct exfat_chain *p_dir,
> > + int num_entries)
> > +{
> …
> > +out:
> > + kfree(clu);
>
> How do you think about to rename the label to “free_clu”?
Yep, Will change it on V2.

Thanks for your review!
>
> Regards,
> Markus



\
 
 \ /
  Last update: 2019-11-18 06:04    [W:0.080 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site