lkml.org 
[lkml]   [2019]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 03/13] exfat: add inode operations
From
Date

> +++ b/fs/exfat/inode.c

> +static int exfat_create(struct inode *dir, struct dentry *dentry, umode_t mode,
> + bool excl)
> +{

+out:
+ mutex_unlock(&EXFAT_SB(sb)->s_lock);

Can the label “unlock” be more appropriate?


> +static struct dentry *exfat_lookup(struct inode *dir, struct dentry *dentry,
> + unsigned int flags)
> +{

> +error:
> + mutex_unlock(&EXFAT_SB(sb)->s_lock);

Would you like to use the label “unlock” also at this place (and similar ones)?


> +static int exfat_search_empty_slot(struct super_block *sb,
> + struct exfat_hint_femp *hint_femp, struct exfat_chain *p_dir,
> + int num_entries)
> +{

> +out:
> + kfree(clu);

How do you think about to rename the label to “free_clu”?

Regards,
Markus

\
 
 \ /
  Last update: 2019-11-17 15:16    [W:0.136 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site