[lkml]   [2019]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 07/10] perf: simplify and rename visit_groups_merge
On Thu, Nov 14, 2019 at 2:03 AM Peter Zijlstra <> wrote:
> On Wed, Nov 13, 2019 at 04:30:39PM -0800, Ian Rogers wrote:
> > To enable a future caching optimization, pass in whether
> > visit_groups_merge is operating on pinned or flexible groups. The
> > is_pinned argument makes the func argument redundant, rename the
> > function to ctx_groups_sched_in as it just schedules pinned or flexible
> > groups in. Compute the cpu and groups arguments locally to reduce the
> > argument list size. Remove sched_in_data as it repeats arguments already
> > passed in. Remove the unused data argument to pinned_sched_in.
> Where did my first two patches go? Why aren't
> {pinned,flexible}_sched_in() merged?

I've merged these 2 patches except for the helper function which is
now trivial with the pinned boolean.


 \ /
  Last update: 2019-11-16 02:21    [W:0.097 / U:4.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site