lkml.org 
[lkml]   [2019]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH resend] libtraceevent: fix parsing event argument types
On Sun, 10 Nov 2019 13:11:01 +0300
Konstantin Khlebnikov <khlebnikov@yandex-team.ru> wrote:

> Add missing "%o" and "%X". Ext4 events use "%o" for printing i_mode.

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Arnaldo, can you take this?

Thanks! (this time I mean it ;)

-- Steve

>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> ---
> tools/lib/traceevent/event-parse.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index d948475585ce..beaa8b8c08ff 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -4395,8 +4395,10 @@ static struct tep_print_arg *make_bprint_args(char *fmt, void *data, int size, s
> /* fall through */
> case 'd':
> case 'u':
> - case 'x':
> case 'i':
> + case 'x':
> + case 'X':
> + case 'o':
> switch (ls) {
> case 0:
> vsize = 4;
> @@ -5078,10 +5080,11 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct tep_e
>
> /* fall through */
> case 'd':
> + case 'u':
> case 'i':
> case 'x':
> case 'X':
> - case 'u':
> + case 'o':
> if (!arg) {
> do_warning_event(event, "no argument match");
> event->flags |= TEP_EVENT_FL_FAILED;

\
 
 \ /
  Last update: 2019-11-13 22:19    [W:0.070 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site