[lkml]   [2019]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[patch V3 00/20] x86/iopl: Prevent user space from using CLI/STI with iopl(3)
This is the third version of the attempt to confine the unwanted side
effects of iopl(). The first version of this series can be found here:

Second version is here:

The V1 cover letter also contains a longer variant of the
background. Summary:

iopl(level = 3) enables aside of access to all 65536 I/O ports also the
usage of CLI/STI in user space.

Disabling interrupts in user space can lead to system lockups and breaks
assumptions in the kernel that userspace always runs with interrupts

iopl() is often preferred over ioperm() as it avoids the overhead of
copying the tasks I/O bitmap to the TSS bitmap on context switch. This
overhead can be avoided by providing a all zeroes bitmap in the TSS and
switching the TSS bitmap offset to this permit all IO bitmap. It's
marginally slower than iopl() which is a one time setup, but prevents the
usage of CLI/STI in user space.

The changes vs. V3:

- Split out the restructuring of the first/subsequent ioperm()
invocation into a seperate patch to address the inconsisteny which
Andy detected in the patch which introduces the concept of
invalidating the I/O bitmap base to speed up context switching.
This change is moved in front so the subsequent changes are
functionally correct.

- Moved the non HW TSS data related to I/O bitmap(s) into a seperate
data structure. Modified version of Ingos proposed patch.

- Made struct memeber names more consistent (Ingo)

- Dropped the bitmap union. It is not longer necessary because V2
already dropped the finer grained copying algorithm. The sequence
count approach should avoid most of the copying overhead when the
number of ioperm() using processes is very low which is the normal

- Dropped the pointer storage of the bitmap in the TSS data as it is
not required (Peter, Andy)

- Fixed the missing refcount setting in the bitmap duplication code
path. (Peter, Andy)

- Updated changelog and comment to explain the bitmap invalidation
logic. (Andy)

- Removed TIF_IO_BITMAP from the TIF flags which are evaluated on the
next task for entering the slow path.

- Folded the NULL pointer check fix

- Simplified the config option in the legacy removal patch (Andy)

- Extended the scope of the config option to disable ioperm() along
with iopl() which also mokes all related storage and functions
compile time conditional. (Andy)

The series is also available from git:

git:// WIP.x86/iopl


arch/x86/Kconfig | 18 ++
arch/x86/entry/common.c | 4
arch/x86/include/asm/io_bitmap.h | 29 ++++
arch/x86/include/asm/paravirt.h | 4
arch/x86/include/asm/paravirt_types.h | 2
arch/x86/include/asm/pgtable_32_types.h | 2
arch/x86/include/asm/processor.h | 113 ++++++++++-------
arch/x86/include/asm/ptrace.h | 6
arch/x86/include/asm/switch_to.h | 10 +
arch/x86/include/asm/thread_info.h | 14 +-
arch/x86/include/asm/xen/hypervisor.h | 2
arch/x86/kernel/cpu/common.c | 188 ++++++++++++----------------
arch/x86/kernel/doublefault.c | 2
arch/x86/kernel/ioport.c | 209 +++++++++++++++++++++-----------
arch/x86/kernel/paravirt.c | 2
arch/x86/kernel/process.c | 200 ++++++++++++++++++++++++------
arch/x86/kernel/process_32.c | 77 -----------
arch/x86/kernel/process_64.c | 86 -------------
arch/x86/kernel/ptrace.c | 12 +
arch/x86/kvm/vmx/vmx.c | 8 -
arch/x86/mm/cpu_entry_area.c | 8 +
arch/x86/xen/enlighten_pv.c | 10 -
tools/testing/selftests/x86/ioperm.c | 16 ++
tools/testing/selftests/x86/iopl.c | 129 ++++++++++++++++++-
24 files changed, 674 insertions(+), 477 deletions(-)

 \ /
  Last update: 2019-11-13 22:02    [W:0.223 / U:1.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site