lkml.org 
[lkml]   [2019]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Input: synaptics-rmi4 - add missed operations in remove
On Wed, Nov 13, 2019 at 04:52:59PM +0800, Chuhong Yuan wrote:
> On Wed, Nov 13, 2019 at 4:23 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > On Wed, Nov 13, 2019 at 02:36:56PM +0800, Chuhong Yuan wrote:
> > > The driver forgets to deal with work and workqueue in remove like what
> > > is done when probe fails.
> > > Add the missed operations to fix it.
> >
> > Is it really possible for the work to still be pending when fully
> > registered device is properly unregistered? I thought we'd wait for
> > successful data acquisition in rmi_f54_buffer_queue() before unregister
> > can complete.
> >
>
> In fact, I am not familiar with the mechanism here...
> I have checked other drivers with video_unregister_device and found none of
> them deals with work in remove.
> Therefore, I think your opinion should be right and we only need to deal with
> the workqueue.

OK, please send the updated patch then.

Thanks!

--
Dmitry

\
 
 \ /
  Last update: 2019-11-13 20:51    [W:0.062 / U:8.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site