lkml.org 
[lkml]   [2019]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4.19 097/125] perf/x86/uncore: Fix event group support
From
Date


On 11/13/2019 5:35 AM, Pavel Machek wrote:
> Hi!
>
>> return ret;
>> }
>>
>> +static void uncore_pmu_enable(struct pmu *pmu)
>> +{
>> + struct intel_uncore_pmu *uncore_pmu;
>> + struct intel_uncore_box *box;
>> +
>> + uncore_pmu = container_of(pmu, struct intel_uncore_pmu, pmu);
>> + if (!uncore_pmu)
>> + return;
>
> AFAICT this test can never trigger.
>
>> +static void uncore_pmu_disable(struct pmu *pmu)
>> +{
>> + struct intel_uncore_pmu *uncore_pmu;
>> + struct intel_uncore_box *box;
>> +
>> + uncore_pmu = container_of(pmu, struct intel_uncore_pmu, pmu);
>> + if (!uncore_pmu)
>> + return;
>
> And neither can this one.

I will submit a patch to fix it.

Thanks,
Kan

\
 
 \ /
  Last update: 2019-11-13 14:04    [W:0.204 / U:27.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site