lkml.org 
[lkml]   [2019]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v9 1/4] dt-bindings: clock: Document external clocks for MSM8998 gcc
From
Date
Hi Jeffrey,

On 11/13/2019 2:14 AM, Jeffrey Hugo wrote:
> The global clock controller on MSM8998 can consume a number of external
> clocks. Document them.
>
> For 7180 and 8150, the hardware always exists, so no clocks are truly
> optional. Therefore, simplify the binding by removing the min/max
> qualifiers to clocks. Also, fixup an example so that dt_binding_check
> passes.
>
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
> ---
> .../devicetree/bindings/clock/qcom,gcc.yaml | 47 +++++++++++++++-------
> 1 file changed, 33 insertions(+), 14 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> index e73a56f..2f3512b 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> @@ -40,20 +40,38 @@ properties:
> - qcom,gcc-sm8150
>
> clocks:
> - minItems: 1
> - maxItems: 3
> - items:
> - - description: Board XO source
> - - description: Board active XO source
> - - description: Sleep clock source
> + oneOf:
> + #qcom,gcc-sm8150
> + #qcom,gcc-sc7180
> + - items:
> + - description: Board XO source
> + - description: Board active XO source
> + - description: Sleep clock source
> + #qcom,gcc-msm8998
> + - items:
> + - description: Board XO source
> + - description: USB 3.0 phy pipe clock
> + - description: UFS phy rx symbol clock for pipe 0
> + - description: UFS phy rx symbol clock for pipe 1
> + - description: UFS phy tx symbol clock
> + - description: PCIE phy pipe clock

Would it be possible to add an example for MSM8998?

>
> clock-names:
> - minItems: 1
> - maxItems: 3
> - items:
> - - const: bi_tcxo
> - - const: bi_tcxo_ao
> - - const: sleep_clk
> + oneOf:
> + #qcom,gcc-sm8150
> + #qcom,gcc-sc7180
> + - items:
> + - const: bi_tcxo
> + - const: bi_tcxo_ao
> + - const: sleep_clk

Not required for SC7180.

> + #qcom,gcc-msm8998
> + - items:
> + - const: xo
> + - const: usb3_pipe
> + - const: ufs_rx_symbol0
> + - const: ufs_rx_symbol1
> + - const: ufs_tx_symbol0
> + - const: pcie0_pipe
>
> '#clock-cells':
> const: 1
> @@ -118,6 +136,7 @@ else:
> compatible:
> contains:
> enum:
> + - qcom,gcc-msm8998
> - qcom,gcc-sm8150
> - qcom,gcc-sc7180
> then:
> @@ -179,8 +198,8 @@ examples:
> clock-controller@100000 {
> compatible = "qcom,gcc-sc7180";
> reg = <0x100000 0x1f0000>;
> - clocks = <&rpmhcc 0>, <&rpmhcc 1>;
> - clock-names = "bi_tcxo", "bi_tcxo_ao";
> + clocks = <&rpmhcc 0>, <&rpmhcc 1>, <0>;
> + clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk";

SC7180 does not require a sleep clock.

> #clock-cells = <1>;
> #reset-cells = <1>;
> #power-domain-cells = <1>;
>

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--

\
 
 \ /
  Last update: 2019-11-13 12:21    [W:0.089 / U:7.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site