lkml.org 
[lkml]   [2019]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.19 097/125] perf/x86/uncore: Fix event group support
Hi!

> return ret;
> }
>
> +static void uncore_pmu_enable(struct pmu *pmu)
> +{
> + struct intel_uncore_pmu *uncore_pmu;
> + struct intel_uncore_box *box;
> +
> + uncore_pmu = container_of(pmu, struct intel_uncore_pmu, pmu);
> + if (!uncore_pmu)
> + return;

AFAICT this test can never trigger.

> +static void uncore_pmu_disable(struct pmu *pmu)
> +{
> + struct intel_uncore_pmu *uncore_pmu;
> + struct intel_uncore_box *box;
> +
> + uncore_pmu = container_of(pmu, struct intel_uncore_pmu, pmu);
> + if (!uncore_pmu)
> + return;

And neither can this one.

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-11-13 11:36    [W:0.500 / U:4.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site