lkml.org 
[lkml]   [2019]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] scripts/tools-support-relr.sh: un-quote variables
On Tue, Nov 12, 2019 at 03:45:20PM +0200, Ilie Halip wrote:
> When the CC variable contains quotes, e.g. when using
> ccache (make CC="ccache <compiler>"), this script always
> fails, so CONFIG_RELR is never enabled, even when the
> toolchain supports this feature. Removing the /dev/null
> redirect and invoking the script manually shows the issue:
>
> $ CC='/usr/bin/ccache clang' ./scripts/tools-support-relr.sh
> ./scripts/tools-support-relr.sh: 7: ./scripts/tools-support-relr.sh: /usr/bin/ccache clang: not found
>
> Fix this by un-quoting the variables.
>
> Before:
> $ make ARCH=arm64 CC='/usr/bin/ccache clang' LD=ld.lld \
> NM=llvm-nm OBJCOPY=llvm-objcopy defconfig
> $ grep RELR .config
> CONFIG_ARCH_HAS_RELR=y
>
> With this change:
> $ make ARCH=arm64 CC='/usr/bin/ccache clang' LD=ld.lld \
> NM=llvm-nm OBJCOPY=llvm-objcopy defconfig
> $ grep RELR .config
> CONFIG_TOOLS_SUPPORT_RELR=y
> CONFIG_ARCH_HAS_RELR=y
> CONFIG_RELR=y
>
> Fixes: 5cf896fb6be3 ("arm64: Add support for relocating the kernel with RELR relocations")
> Reported-by: Dmitry Golovin <dima@golovin.in>
> Link: https://github.com/ClangBuiltLinux/linux/issues/769
> Cc: Peter Collingbourne <pcc@google.com>
> Signed-off-by: Ilie Halip <ilie.halip@gmail.com>
> ---
> scripts/tools-support-relr.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

Thanks, I'll queue this as a fix.

Will

\
 
 \ /
  Last update: 2019-11-13 11:31    [W:0.072 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site