lkml.org 
[lkml]   [2019]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch V2 09/16] x86/ioperm: Move TSS bitmap update to exit to user work
On Tue, Nov 12, 2019 at 09:46:30AM -0800, Linus Torvalds wrote:

> I think it's just that the pattern to find "start of new function" is
> confused by the "__visible" or something.
>
> Don't rely too much on the function names in the diff headers. They
> can be confused by labels, or just by other things. I think it ends up
> being "does the line start with alphabetic character" that is the
> heuristic for "this is a function header".

Right, so I have this in my .gitconfig:

[diff "default"]
xfuncname = "^[[:alpha:]$_].*[^:]$"

Which works nice for C in that it will no longer accept labels as
funcname, but it stinks for ASM :-)

\
 
 \ /
  Last update: 2019-11-13 09:31    [W:0.112 / U:2.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site