lkml.org 
[lkml]   [2019]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2] Input: synaptics-rmi4 - add missed operations in remove
Date
The driver forgets to destroy workqueue in remove like what
is done when probe fails.
Add a call to destroy_workqueue to fix it.

Since unregistration will wait for the work to finish, we do
not need to deal with work in remove.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
Changes in v2:
- Remove the calls of canceling delay and flushing workqueue.
- Modify the commit message.

drivers/input/rmi4/rmi_f54.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
index 484ae1f97330..897105b9a98b 100644
--- a/drivers/input/rmi4/rmi_f54.c
+++ b/drivers/input/rmi4/rmi_f54.c
@@ -730,6 +730,7 @@ static void rmi_f54_remove(struct rmi_function *fn)

video_unregister_device(&f54->vdev);
v4l2_device_unregister(&f54->v4l2);
+ destroy_workqueue(f54->workqueue);
}

struct rmi_function_handler rmi_f54_handler = {
--
2.23.0
\
 
 \ /
  Last update: 2019-11-14 03:35    [W:0.041 / U:1.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site