Messages in this thread |  | | From | Masahiro Yamada <> | Date | Tue, 12 Nov 2019 16:53:49 +0900 | Subject | Re: [PATCH] mm: fixmap: convert __set_fixmap_offset() to an inline function |
| |
Hi Andrew,
On Fri, Nov 8, 2019 at 9:42 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > I just stopped by the ugly variable name, ________addr. > (8 underscores!) > > If this is just a matter of casting to (unsigned long), this variable > is unneeded since you can do like this: > > ({ \ > __set_fixmap(idx, phys, flags); \ > (unsigned long)(fix_to_virt(idx) + ((phys) & (PAGE_SIZE - 1))); \ > }) > > However, I'd rather like to change it to an inline function since it > is more readable, and the parameter types are clearer. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Unfortunately, this patch broke building ppc, mips, etc. (Not all arch implement __set_fixmap)
Could you drop it from your tree?
Thanks.
-- Best Regards Masahiro Yamada
|  |