lkml.org 
[lkml]   [2019]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 40/62] gpio: gpio-siox: Use new GPIO_LINE_DIRECTION
Date
Hello Thorsten,

On Mon, 2019-11-11 at 08:27 +0100, Thorsten Scherer wrote:
> Hello,
>
> On Tue, Nov 05, 2019 at 12:30:58PM +0200, Matti Vaittinen wrote:
> > It's hard for occasional GPIO code reader/writer to know if values
> > 0/1
> > equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and
> > GPIO_LINE_DIRECTION_OUT to help them out.
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
>
> for SIOX gpio:
>
> Acked-by: Thorsten Scherer <t.scherer@eckelmann.de>
>
> > Patches are compile-tested only. I have no HW to really test
> > them. Thus
> > I'd appreciate carefull review. This work is mainly about
> > converting
> > zeros and ones to the new defines but it wouldn't be first time I
> > get it wrong in one of the patches
> > :)
>
> Applied the patch(es) and tested them with SIOX device
>
> Tested-by: Thorsten Scherer <t.scherer@eckelmann.de>
>

Big thanks! It's _really_ nice that someone takes the time to do the
testing! Highly appreciated! :]

Br,
Matti Vaittinen
\
 
 \ /
  Last update: 2019-11-11 08:44    [W:0.061 / U:1.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site