lkml.org 
[lkml]   [2019]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4 3/4] soc: amlogic: Add support for Secure power domains controller
Date
Hi Jianxin,

Jianxin Pan <jianxin.pan@amlogic.com> writes:

[...]

>>> + SEC_PD(RAMB, GENPD_FLAG_ALWAYS_ON),
>>> + SEC_PD(IR, 0),
>>> + SEC_PD(SPICC, 0),
>>> + SEC_PD(SPIFC, 0),
>>> + SEC_PD(USB, 0),
>>> + /* NIC is for NIC400, and should be always on */
>>
>> Why?
>>
> NIC domain is for ARM CoreLink NIC-400 Network Interconnect, and should be always on since bootloader.

OK, makes sense. I suggest a minor change to the comment to remind that
this is an interconnect:

/* NIC is for the Arm NIC-400 interconnect, and should be always on */

Thanks,

Kevin

\
 
 \ /
  Last update: 2019-11-11 15:44    [W:0.100 / U:7.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site