lkml.org 
[lkml]   [2019]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/5] perf record: Put a copy of kcore into the perf.data directory
From
Date
On 7/10/19 2:20 PM, Jiri Olsa wrote:
> On Fri, Oct 04, 2019 at 11:31:21AM +0300, Adrian Hunter wrote:
>
> SNIP
>
>> bool strict_freq;
>> bool sample_id;
>> bool no_bpf_event;
>> + bool kcore;
>> unsigned int freq;
>> unsigned int mmap_pages;
>> unsigned int auxtrace_mmap_pages;
>> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
>> index 061bb4d6a3f5..bfa80fe8d369 100644
>> --- a/tools/perf/util/session.c
>> +++ b/tools/perf/util/session.c
>> @@ -230,6 +230,10 @@ struct perf_session *perf_session__new(struct perf_data *data,
>> if (ret)
>> goto out_delete;
>> }
>> +
>> + if (!symbol_conf.kallsyms_name &&
>> + !symbol_conf.vmlinux_name)
>> + symbol_conf.kallsyms_name = perf_data__kallsyms_name(data);
>
> hum, should this also depend on rec->opts.kcore ?

This is the bit that makes 'perf script' work. It has the same affect as
though the --kallsyms option was used. i.e. it makes 'perf script' behave
the same as:

perf script --kallsyms perf.data/kcore_dir/kallsyms

Which works because perf looks for kcore in the same directory as kallsyms.

\
 
 \ /
  Last update: 2019-10-07 14:17    [W:0.125 / U:8.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site